Pull requests on github

Post Reply
david garyga

Hi,

I've oppened 2 pull requests on github 1 month ago, and I see no answer as of today.

You may not have the time to look at them, or maybe you don't receive github notifs ?
Should I open a thread on sourceforge for each pull request ? Do you have a preferred procedure ?

Just a simple question, I know you're very busy !


Regards.
Top
Jano Svitok

I'll answer in reverse order:

I suppose PR's are OK for code patches and translations. Fixture definitions have own forum section. You don't have to open thread on SF. I do get github notifications, and I suppose so does Massimo.

I have seen your PR's and even briefly tried to reproduce the problem with fixture deleting. Then I got to do something else and haven't returned back. Now I'm too busy with real life to do anything more.
Top
david garyga

Thanks !

So, should I open a thread for discussing a feature/change request ?
Top
Massimo Callegari

Hello David,
I did receive your PR and it's in my TODO list.
Just haven't had the time to check it out.
Please be patient but I think your change will be included in the next QLC+ version.

Thanks
Top
Post Reply

Return to “Software Development”