Page 1 of 1

Suspected Overflow in Timings

Posted: Sun Jun 07, 2015 3:32 pm
by tornel
Hi!

I'm getting some strange behaviour in Chaser and Show Timings.

To reproduce:
1. Create Scenes
2. Create Chaser
3. Add Scenes to Chaser
4. Set timings to "Common" (the bug doesn't show if set as "Per Step" or "Default")
5. Change Fade In timing
6. BAMM! the Hold time is automatically changed to something like 1193 hours and some minutes

The workaround is to change the Hold time and it resets itself to the correct time, however if you change the Fade In then the strange behaviour happens again.
The same thing occurs in Show (sequence) timings.

I'm attaching Workspace and Screenshot.

Additional Info:
Ubunutu 14.10
QLC+ 4.9.0 GIT (QT5)

As always if you need more info don't hesitate to ask!
Thanks!

Re: Suspected Overflow in Timings

Posted: Tue Jun 09, 2015 9:37 pm
by janosvitok
Confirmed. Duration = Fade In + Hold, so Hold = Duration - Fade In. When Fade In > Duration then Hold is negative. Since Hold is a 32 bit number, -1 is 0xFFFFFFFF or roughly 1193 x 60 (m) x 60 (s) x 1000 (ms)

Re: Suspected Overflow in Timings

Posted: Tue Jun 09, 2015 10:31 pm
by janosvitok

Re: Suspected Overflow in Timings

Posted: Thu Jun 11, 2015 4:19 pm
by plugz
Hi,

Now fixed in git.

Re: Suspected Overflow in Timings

Posted: Thu Jun 11, 2015 8:53 pm
by tornel
Great Work!!!

I'll test it tonight

Re: Suspected Overflow in Timings

Posted: Fri Jun 12, 2015 3:11 am
by tornel
it works!
Thanks!