Firstly, thanks you for this great open source software. I didn't use it a lot yet but this will change in the future, I plan to use it for parties and shows...
I am currently create a fixture definition with the editor (and will share it, of course
).While creating the fixture I noticed a bug when editing a channel, more precisely when editing a capability. If you create a capability with the same values as min and max, when you create the next capability, the default min value is the value you used in the last capability, and not the last value + 1.
Example :
- I create a strobe channel
- I create a first capability, min and max values : 0 (no strobe)
- I create a second capability, the default values are min=0 and max=255. Min default value should be 1
- I tried with another value than 0 for the function, the problem is the same : if a create a first cap min0 max19, then a second cap min20 max20, the default min value for the third is 20 instead of 21.
This is not a big issue but still, this can be annoying
Sylvain
edit: I understand the problem is coming from fixtureeditor/editchannel.cpp, lines 237 to 241.
I think having "cap->max() >= minFound" (large comparison ">=") would resolve the problem.
A new issue would be minFound == 256, in this case a qdialog would do the trick to warn the user he can't add a new capability.
edit 2 : actually, there can be situations where minFound == 256 but the user can add capabilities, if he let a gap, example : first cap 0->10, second cap 20->255. There is nothing between 11 and 19 yet but minFound will be 256 anyway.