Q Light Controller+

Hi Massimo:

First of all some context:

I've just learned in these last weeks to compile (in linux... as you said in some other post... compiling in windows is a pain in the ass) to see and make corrections to the translation i'm working on. Is in this context that I've found the following issues:

1.- In the new and shining Wizard the word "Next" in the button does not appear (I presume its out of place because in the translation to another language appears just part of the word). Since a image worths a thousand words I've attached two screenshots .

2.- When you delete a folder there is a small typo in the string that says: "Do you want to DELETE foler:" (should say folder)

3.- There are buttons that are are not translated, in fact, there are no strings in the .ts files to translate them. (e.g. In the "Do you want to save the current workspace...." popup, the buttons "Yes" "No" and "Cancel" are still in english)

4.- And finally, and the more important issue: After the last merge (new Wizard), the Package Creation for Ubuntu fails. However with *make* it compiles OK.

here are the last lines in the terminal:

~~~~~~
********* Finished testing of RGBText_Test *********
~/qlcplus
~/qlcplus ~/qlcplus
./unittest.sh: line 22: ./test.sh: No such file or directory
~/qlcplus
127 Engine unit tests failed. Please fix before commit.
make[1]: *** [check] Error 127
make[1]: Leaving directory `/home/luis/qlcplus'
dh_auto_test: make -j1 check returned exit code 2
make: *** [build] Error 29
dpkg-buildpackage: error: debian/rules build gave error exit status 2
~~~~~~

Additional info:
QLC+ version: 4.6.0 (Just compiled from the source )
OS: Virtual Machine whith Ubuntu 12.04 (64 bits)

Hi Luis, I just replied to you via email...just to realize you wrote here !

Thanks for the detailed report. I appreciate it.
1- I hoped that wouldn't happen...and still. I don't know why but Qt doesn't handle very well the icon alignment into buttons. I'll see how to fix it.

2- You're absolutely right ! Gonna fix it ! (that's what happens when writing code at night ). By the way, do you like the new wizard ? There's a lot of space of improvement, but that's how I thought it to be.

3- I know. That's Qt, not QLC+. Default dialog windows show Qt internal strings, which in this case are not translated in your language (nor in mine). If we lived in Germany we wouldn't probably have noticed that

4- i just built the DEB and got no error (apart for a stupid changelog date check). Maybe you need to clone the repository from scratch or do a "make distclean". Lot of stuff has been added lately so you might have an unclean tree

Massimo:

I'm absolutely loving the new wizard, of course there are some things to improve.

In the next days I'm gonna experiment and test it thoroughly, however for the moment I can say I miss the option to make solo frames instead of the normal ones, specially with the colors.

And also found a bug, I think.

In the last tab of the wizard, when are not selected ALL of the functions of a frame, the frame, and therefore the widgets in it, are not created in the VC.

About the DEB, after trying a lots of things I finally managed to build it, erasing the fork I have and re-cloning...

Hi Luis, hi had your same idea last night and today I implemented it. Now buttons are grouped in a solo frame.
I also fixed the partially checked items issue.
Also, the "next" button should be OK now. Can you please check when you have the chance ?

Thanks

Hi Massimo, I've just made a quick check, and all works fine!!!