Q Light Controller+

• update-core is now deprecated, and it says "-bash: update-core: command not found"

• The download link in the documentation http://www.qlcplus.org/downloads.html does not exist, now it should be changed to download.php

• gendef.exe and dlltool are not found.

mcallegari wrote: ↑Mon Mar 20, 2023 8:23 am Have a look at this
https://github.com/mcallegari/qlcplus/b ... pveyor.yml

This is how every commit to QLC+ is built on Windows (and as you can see gendef and dlltool are there)

 # patch Qt 5.15.x to build with GCC 12
cd /c/msys64/mingw32/include/
sed -i -e 's/friend Q_CORE_EXPORT uint qHash/\/\/friend Q_CORE_EXPORT uint qHash/g' QtCore/qbitarray.h
sed -i -e 's/friend Q_NETWORK_EXPORT bool operator==/\/\/friend Q_NETWORK_EXPORT bool operator==/g' QtNetwork/qssldiffiehellmanparameters.h

    friend Q_GUI_EXPORT QDataStream &operator<<(QDataStream &, const QColor &);
    friend Q_GUI_EXPORT QDataStream &operator>>(QDataStream &, QColor &);

friend Q_CORE_EXPORT uint qHash(const QLocale &key, uint seed) noexcept;

friend Q_CORE_EXPORT uint qHash(const QRegularExpression &key, uint seed) noexcept;

friend Q_CORE_EXPORT uint qHash(const QUrl &url, uint seed) noexcept;

friend Q_CORE_EXPORT uint qHash(const QUrlQuery &key, uint seed) noexcept;

    friend Q_GUI_EXPORT QDataStream &operator<<(QDataStream &in, const QKeySequence &ks);
    friend Q_GUI_EXPORT QDataStream &operator>>(QDataStream &in, QKeySequence &ks);
    friend Q_GUI_EXPORT uint qHash(const QKeySequence &key, uint seed) noexcept;

    friend Q_GUI_EXPORT QDataStream &operator>>(QDataStream &, QPen &);
    friend Q_GUI_EXPORT QDataStream &operator<<(QDataStream &, const QPen &);

mcallegari wrote: ↑Mon Mar 20, 2023 10:10 am Again, please have a look at what I mentioend before, from this line
https://github.com/mcallegari/qlcplus/b ... or.yml#L48

However, please consider moving to Linux as a developer-friendly environment to build and debug.
Windows is not really a good choice to contribute to this project
macOS is halfway but still has deployment complications

[EDIT] moved this thread to the proper place

mcallegari wrote: ↑Mon Mar 20, 2023 3:22 pm cmake is recommended for Qt 6 and QLC+ hasn't switch to it yet. Now times are more mature, so we can discuss about it.
There's a quite bad PR that was supposed to evolve but got closed that include porting to cmake
https://github.com/mcallegari/qlcplus/pull/1214
There might be effort but this can help
https://wiki.qt.io/CMake_Port/Porting_Guide
and this
https://pypi.org/project/qmake2cmake/

Not sure what is the sense of using MSVC when all dependencies come from MSYS2 (fftw, sndfile, flac, ogg, mad, libusb, etc)
Basically you need to disable audio and plugins, so build an almost useless QLC+ version

• Will we need to upgrade from QT5 to QT6 for QLC++ 5?
  As far as I know, the current version of QLC++5 is using qt5.
  And I am wondering if we need to upgrade the version of QT.
  I guess there will be so many issues with upgrading the qt version.
  And QT6 is a commercial version, but not free.
  So we need to make a serious decision about it.

• Next question. Don't we need to make the versions of the Development environment fixed?
  In the original building system using Msys2, it simply installs mingw32/mingw-w64-i686-qt5, and we will never know which version of qt5 it will install for us.

mcallegari wrote: ↑Wed Mar 22, 2023 7:57 am - QLC+ 5 on Qt 6 is just a no right now. QLC+ 4 on Qt 6 works already
And no. Qt 6 is not commercial. Only certain minor releases of LTS versions. Also, sources are available after some months of exclusivity (thanks to KDE yay!) so even those commercial versions can be built from sources. In fact MSYS2 delivers Qt 5.15.8 which was commercial when it was released
- No. Qt 6 is not a need (yet). Please let's stick to Qt 5 for some more time.

• 1. What is the difference between QLC++4 and 5?
  As far as I know, QLC++5 is still in the beta version.
  So is QLC++5 just an extension of QLC4++?
  And do I just need to build a CMake compilation system based on the current master branch?

• 2. Just want to confirm, which version of QT are we going to use for building QLC++? If I didn't misunderstand, we will use qt5 at the moment for some more time, right?

mcallegari wrote: ↑Wed Mar 22, 2023 12:58 pm QLC+ 4 UI is based on Qt Widgets
QLC+ 5 UI is based on QML
The engine is 95% shared between the two versions.
Both use qmake and need to be ported to cmake.
Qt6 support is already in place for QLC+ 4 and is in progress for QLC+ 5 (qmltoqt6 branch) This also needs to be included in the port to cmake.
So QLC+ 4 can be built on Qt 5.15.x or Qt 6.4.x while QLC+ 5 can be built only on Qt 5.14.x/5.15.x

I hope this clear things up

• qtdeclarative5-dev

• libqt5svg5*

• qt3d5-dev

• qml-module-qtquick-controls

• qml-module-qtquick-controls2

• qml-module-qtquick-dialogs

error: Unknown module(s) in QT: qml svg 3dcore 3drender 3dinput 3dquick 3dquickextras

module "QtQuick.Controls" is not installed

module "QtQuick.Dialogs" is not installed

It is recommended to use the official Qt versions available here: https://www.qt.io/download-open-source/

mcallegari wrote: ↑Thu Mar 23, 2023 7:57 am The wiki for QLC+ 5 build says this:

It is recommended to use the official Qt versions available here: https://www.qt.io/download-open-source/

Using the Qt version provided by the OS led to issues in the past.

    quint32 maxChannels = 512;

    /* Construct a map of unallocated channels */
    int map[maxChannels];

Variable-length arrays (VLAs) are not supported in MSVC. VLAs are a C99 feature, and MSVC only supports C89/C90 and C++ standards up to C++17.