Page 1 of 1

Crash editing fixture definition

Posted: Tue Jan 24, 2023 12:41 am
by giacomo
First crash of 2023!
Yestalgia, I won a present, isn't it? ;)

. start v.5 beta 2 and go to Add Fixtures > generic > and select generic dimmer
. click "edit the selected fixture definition" > v.5 crashes

I guess the answer is here:

[FixtureBrowser] Models list for "Generic"
[FixtureBrowser] Modes list for "Generic" "Generic Dimmer"
[FixtureBrowser] Modes list for "Generic" "Generic Dimmer"
[FixtureBrowser] Modes list for "Generic" "Generic Dimmer"
[FixtureBrowser] Modes list for "Generic" "Generic Dimmer"
[FixtureBrowser] Modes list for "Generic" "Generic Dimmer"
qml: mf: Generic, mdl: Generic Dimmer, mode:
qml: addr: 1, ch: 1
Key release event received: "\t"
qml: mf: Generic, mdl: Generic Dimmer, mode:
qml: addr: 1, ch: 1
Key release event received: "\t"
working path: "file:///home/giacomo/.qlcplus/fixtures"
qrc:/FixtureEditor.qml:95: TypeError: Cannot read property 'manufacturer' of undefined
Segmentation fault

I tried some other fixtures and it seems to crash only with the generic dimmer selected.

Re: Crash editing fixture definition

Posted: Tue Jan 24, 2023 2:43 am
by Yestalgia
giacomo wrote: Tue Jan 24, 2023 12:41 am First crash of 2023!
Yestalgia, I won a present, isn't it? ;)
Haha absolutely! :D

Re: Crash editing fixture definition

Posted: Sat Jan 28, 2023 2:55 pm
by mcallegari
So you tried to edit the only fixture among 1400+ which cannot be edited! :D
But OK, this is a useful report too

Re: Crash editing fixture definition

Posted: Sat Jan 28, 2023 3:55 pm
by rajones203
Massimo,

Staying on this topic. I love the new fixture editor built into the program itself. Smooth operation so far. I have a pretty repeatable crash when trying to pick a pre-made channel profile. Click the dropdown, select any of the Intensity, Color, etc.... Program crashes.

Could this be an issue of having v4 still on the system? (OSX)

Re: Crash editing fixture definition

Posted: Sat Jan 28, 2023 5:22 pm
by giacomo
@Massimo
I know but it's the one selected by default so better to fix it ;)

Re: Crash editing fixture definition

Posted: Sat Jan 28, 2023 5:46 pm
by mcallegari
Of course, I fixed both reports
Thanks @Russell too

By the way, including the fixture editor inside QLC+ is mainly for macOS, to avoid having the annoying launcher.
This obviously introduce new possibilities like testing a fixture while editing it, or even adding/modifying a fixture without leaving QLC+

Re: Crash editing fixture definition

Posted: Sat Jan 28, 2023 7:29 pm
by Yestalgia
mcallegari wrote: Sat Jan 28, 2023 5:46 pm This obviously introduce new possibilities like testing a fixture while editing it, or even adding/modifying a fixture without leaving QLC+
The Open Fixture Library will love this!