Numbering of Playback sliders

The issues found when using the Simple Desk panel
Post Reply
jpearson0525
Posts: 4
Joined: Thu Jul 30, 2020 12:35 am
Real Name: James Pearson

The number of the Cue Stack playback sliders has two # 15 sliders.

Version 4.12.2, Raspbian Buster based on Raspberry Pi 3 B+.

JIm.
kenact
Posts: 441
Joined: Thu Apr 23, 2015 6:43 am
Real Name: Ken Coughlin

t does in Windows too.
User avatar
edogawa
Posts: 633
Joined: Thu May 07, 2015 10:34 am
Real Name: Edgar Aichinger

I think I found where in the code that happens, it's just an issue with displaying, internal numbering is ok.

I just recompiled an it displays correctly now. Before, at resizing the window, the doubled number always appeared when a new playback slider got added, that led me to looking for resize code.

I don't have time today to make a proper Github pull request, but as it's such a trivial change, maybe @Massimo can you just pick it up from here please?

ui/src/simpledesk.cpp, line 1681 should add 1 to the slider count.

Code: Select all

                slider->setLabel(QString::number(m_playbackSliders.count()));
should be changed to

Code: Select all

                slider->setLabel(QString::number(m_playbackSliders.count()+1));
User avatar
mcallegari
Posts: 4727
Joined: Sun Apr 12, 2015 9:09 am
Location: Italy
Real Name: Massimo Callegari
Contact:

Sure, I'll have a look at this maybe later today.
Thanks for reporting

[EDIT] just pushed upstream
Post Reply