OBS Ubuntu builds are outdated.

[janosvitok]

It seems ubuntu OBS builds are failing:

https://build.opensuse.org/package/live ... .04/x86_64

Code: Select all

[  496s] /usr/src/packages/BUILD/resources/fixtures/scripts /usr/src/packages/BUILD
[  497s] Fixtures: OK
[  497s] /usr/bin/env: 'python': No such file or directory
[  497s] /usr/src/packages/BUILD
[  497s] Fixture definitions are not valid. Please fix before commit.
[  497s] make[1]: *** [Makefile:629: check] Error 127
[  497s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  497s] dh_auto_test: error: make -j6 check returned exit code 2
[  497s] make: *** [debian/rules:8: build] Error 25
[  497s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2

Maybe it's time to drop python2 support?
https://github.com/mcallegari/qlcplus/b ... tool.py#L1
also
https://github.com/mcallegari/qlcplus/b ... ol.py#L245
and similar.

Note that ubuntu released 22.10, but I could not determine if OBS already supports it.

Jano

[hansjuergen]

There is a package "python-is-python3" which can be installed to let it find python again as "python". That will solve the issue better than renaming the command in the file header, as it matches the progam name in environments which install python directly and do not rename the binary while packaging.
Rather than renaming, the package maintainers should have use paths and the update-alternative infrastructure to handle the issue of different versions, but that's another story.

[edogawa]

Thanks for bringing this up, I was (and still am) rather busy in my main job and haven't noticed the broken ubuntu builds.

It seems that this commit is the culprit:
https://github.com/mcallegari/qlcplus/c ... 75d33eb257

This introduces a new build dependency python-lxml, used during unit tests.

As distros are phasing out python2 support, i wonder if it's such a great idea to introduce new build deps on python2 dependent packages. I see that there is a debian package variant python3-lxml, would it be possible to depend on this instead?

EDIT: I'm trying with python-is-python3 in my home branch currently.

Oh, and 22.10 is available in OBS, it's not yet offered in the webui though.

I'll happily add this, but I wonder if I should in turn get rid of older distro variants, to keep the build queue from ever growing? And if yes, which ones (I don't use Ubuntu but generally I'd propose a policy like "support all variants back to the previous LTS version"), but I'd have to look up which one that is...

[edogawa]

I'm sorry if my above remarks are a bit confusing and for repeatedly editing the posting, Jano identified the problem in fixture-tool, still it's mysterious to me why the tests succeeded using python3, before Sep, 26 ... because we didn't pull in python2 either at that time, AFAIR.

I'm checking and trying out things with dependencies and python backwards compatibility package as suggested, trying to come up with as little overhead as possible. things look good so far.

[edogawa]

Ubuntu builds are working again. I added both python-is-python3 and python3-lxml as build dependencies in .control and .dsc