Vertical Fallovertakes color of first instance

[coolaturon]

Hi, I found a bug that quite bothers me, while creating a show.

How to reproduce:

• Go to function Manager.

• Create a New RGB-Matrix Function

• Select "Vertical fall" as preset and assign it green as a color (0,255,0)

• Save it

• Create another RGB-Matrix Function and assign it the color red (255,0,0)

What I expected:

• Every Function keeps its specifiactions and is played like it was set up

What actually happened:

• The first (green) function is now also played in red color.

Environment: v4.12.3 on Win10 Pro (v2004 Build 19041.685)

Thanks for helping out

[kenact]

Can you post your project, please?

[coolaturon]

Hi, of course, here you go.

[GGGss]

Confirmed ... while changing RGB matrici, the chosen color values get stuck internally.
Adopted the project file with a 2D view & 2 buttons on the VC.

It is even worse, that you have to close QLC+ to reset this behavior. (!)

[kenact]

I did some testing with this, and it only appears to happen with the Vertical Fall. It seems the last color you select for a vertical fall is what all other vertical fall matrices change to.

The good thing is, if you save your project, load a different project, then reload your original project, everything works normally, UNTIL you click on a Vertical Fall in the Functions Screen.

[MKUltraMkII]

I am also reproducing this issue on QLC+ 4.12.3 on macOS 10.15.7.

An additional thing I have found:

In my Virtual Console, I have a panel with buttons that toggle various Vertical Fall animations of different colors. As I toggle these buttons, the colors don't seem to change (possible related bug), but instead, the speed of the Vertical Fall animation seems to multiply (or divide the duration, rather) by the number of vertical fall buttons toggled on (not sure if this is related to the original bug, or different).

I do have a single speed dial connected to each of my vertical fall animations, and I also probably created them by copy & pasting the first vertical fall, and then changing its color. I will have to check and see if creating each animation new instead of copy paste make any difference.

Sorry for my large project- but the behavior can be seen by enabling the 2D view, then toggling a few buttons in the "Vertical Fall" panel at the bottom center of my Virtual Console.

[sandinak]

Ok .. Verified behavior in 4.12.3 on MacOS. I checked out the Javascript and tested it a few times and a few different ways:

• Downloaded the example scripts here.. validated bad behavior in DMX view under Run mode .. and by moving between Matrix scripts.
• Tried testing the script in the devtool.html and couldnt' get it to fail .. tried several different ways and it worked consistently.
• Tried updating the running script a few ways.. and wasn't able to remove bad behavior. I even tried converting the script to api v2.

One note .. I was able to successfully 'reset' the situation and get the right color by firing off a different RGB script between them. My c++ is merde.. so no luck identifying it in the code base,.

[Lampy101]

I just discovered this bug building a show! Damn I was going heavy on vertical falls as well!

[mcallegari]

Fixed upstream, thanks for reporting
The fixed script is here
https://github.com/mcallegari/qlcplus/b ... calfall.js

[Lampy101]

Awesome thank you! I was considering replicating a bunch of falls as sequences so that is an amazing fix.