Fixture editor bug

boxy · Thu Nov 12, 2015 12:02 pm

Hi,

I think I've found a stabilty bug in the latest Fixture Editor (v4.10.1).

When editing capabilities for a large definition the editor will suddenly go 'write only' and disallow further additions to the list. Exiting and then reentering the <edit channel> dialogue eventually crashes the software.

The attached file is now in a state where the red plus button is no longer responsive at all.

Is there a limit to the number of capabilities in a channel? There's no indication if it is 40 that this is so. Take a look at the FX Wheel attached.

Boxy

plugz · Thu Nov 12, 2015 12:41 pm

Workin' on it...

plugz · Thu Nov 12, 2015 1:03 pm

Steps to reproduce a crash:

- create a new channel
- Add a capability with the + button, don't touch its parameters. This cap will cover the value range 0-255
- Click on the + button again, this will not create a new cap. This is because the whole 0-255 range is already used. -> This is what you think is a bug

- Now change any of the parameters of the currently selected. The FixtureEditor will crash. -> This is a real stability issue, that will be resolved pretty soon

boxy · Thu Nov 12, 2015 1:13 pm

I see that bug clearly. Not letting me add another range (between 191 and 235 on FX Wheel (Wheel 3) in the Martin fixture is a different bug though? This range is not occupied.

If was my attempts to add the above that created the reproducible crash.

Good work.

boxy · Thu Nov 12, 2015 1:22 pm

This screenshot shows the main S/W with 40 capabilities on a channel (not complete or checked or anything). Is it telling me QLC+'s screen is full up?

plugz · Thu Nov 12, 2015 1:24 pm

boxy wrote:I see that bug clearly. Not letting me add another range (between 191 and 235 on FX Wheel (Wheel 3) in the Martin fixture is a different bug though? This range is not occupied.

I reproduce this bug on 4.10.1 but not with the latest sources. Must have been fixed after the release of 4.10.1

mcallegari · Thu Nov 12, 2015 1:24 pm

plugz wrote:
boxy wrote:I see that bug clearly. Not letting me add another range (between 191 and 235 on FX Wheel (Wheel 3) in the Martin fixture is a different bug though? This range is not occupied.
I reproduce this bug on 4.10.1 but not with the latest sources. Must have been fixed after the release of 4.10.1

Yep, I think I have done some more changes as I was not happy about the initial code.
I'll try the same later today.
@boxy: as the official fixtures reviewer, it would be nice if you can always be up to date with the developments. Yesterday I built a Windows TEST version. Can you please try that and see if it works now ?

boxy · Thu Nov 12, 2015 1:41 pm

I don't have admin rights on my Windows machine so installing from source is very difficult (installing the relevant apps). I can try from Linux but not managed a successful build yet.

Indeed, I have to use my phone as a hotspot to update QLC+ anyway (via a certain network...) as it is now blocked!

Installing test version now...

boxy · Thu Nov 12, 2015 1:59 pm

You guys can sleep at night for a bit now...

boxy · Fri Nov 13, 2015 10:01 am

The crashing bug is still there with the new code.

There are also frustrating constraints which stop you renumbering capability ranges within a channel. I want to move 'Inverse Square Law Dimming' from 20-25 to 70-74 and it won't have it, even though the latter range is empty. I may have to do some manual xml editing to get this done.

plugz · Fri Nov 13, 2015 10:16 am

Hi,

boxy wrote: The crashing bug is still there with the new code.

Did you build from the latest sources, or did you use a TEST version ?

boxy wrote:There are also frustrating constraints which stop you renumbering capability ranges within a channel. I want to move 'Inverse Square Law Dimming' from 20-25 to 70-74 and it won't have it, even though the latter range is empty. I may have to do some manual xml editing to get this done.

Still the same MAC Quantum fixture ? Which channel ?

boxy · Fri Nov 13, 2015 11:15 am

I used the TEST version from the link in this thread.

I've just posted the MAC Viper Profile fixture in the Fixture Requests forum. It was easier to edit the xml for the Control/Settings channel - I would rather the editor do a check when I press OK instead of preventing the user from moving things around during changes.

plugz · Fri Nov 13, 2015 11:59 am

boxy wrote: I used the TEST version from the link in this thread.

The test version contains the fix for the "Cannot add a channel even though there is available space" bug. It does not contain the fix for the crash yet

boxy wrote: I've just posted the MAC Viper Profile fixture in the Fixture Requests forum. It was easier to edit the xml for the Control/Settings channel - I would rather the editor do a check when I press OK instead of preventing the user from moving things around during changes.

I'll see if I can do something.

mcallegari · Fri Nov 13, 2015 12:12 pm

Should I build a new Windows TEST version ?

plugz · Fri Nov 13, 2015 4:08 pm

[WORK IN PROGRESS]

Boxy, would this be better ?

You can enter any value, but as long as the range is invalid, it won't be applied to the capability.

(implementation here: https://github.com/plugz/qlcplus/tree/e ... ow-invalid )

boxy · Sun Nov 15, 2015 9:21 am

Plugz, that looks better. Maybe the comment should be 'Range in use'.

Good