4.8.3 Chase Bug

[FactorFilms]

So it looks like version 4.8.3 (OSX: QLC+_4.8.3-TEST-20141212.dmg) introduces a bug into shows, and their chases in general.

I have a show that plays a wav file, and creates a 'strobe flash' every 15 seconds for .01 hold, in time with a wav soundtrack. (basically All LEDs @ 100% for .01, then back to black for 15 seconds)

Worked beautifully in 4.8.2, but now when the first flash hits 100%, it keeps outputting 100% values indefinitely, instead of going back to 0%. This also happens if the length of the hold is extended to 1 second - it still just holds @ 100%.

This occurs both in the show, or if the chase is played on its own via the Virtual Console. It evens happens when the chase is previewed in the function manager, though the individual 'steps' output correctly when clicked through one by one with blind mode off.

[david garyga]

Hi,

Can you please share a workspace file ?

Thanks

[Massimo Callegari]

Wrong forum. A TEST version is development.
Moved.

[FactorFilms]

Here's the file. Run the show, and there are strobe flashes every 15 seconds. But on 4.8.3 they all turn on and stay on. It even shows this is the DMX being output in the monitor.

I've added both the show, and the flash chase sequence on its own as buttons on the Virtual Console. All playback incorrectly.

[Massimo Callegari]

The regression is confirmed.
@David: I'm trying to go back through GIT commits to find out which one caused this.
At the moment my suspects go to https://github.com/mcallegari/qlcplus/pull/398

A Sequence is a special Chaser where all the steps are the same Scene with the same ID.
Please let me know if this rings a bell to you to speed up fixing this issue.

This is blocking for the 4.8.3 release.

[Massimo Callegari]

Found. It's PR #404

commit 95bc303b8624e1a2371f9dadbfe8aa0b59da218a
Date: Mon Nov 17 12:11:26 2014 +0100

Fix issue with function staying ON in a fast running chaser

[Massimo Callegari]

Further note. I reverted that change on GIT master sources.
In particular, what cause this issue is the change to function.cpp
https://github.com/plugz/qlcplus/commit ... 18a#diff-1

Moving the m_stop flag is very dangerous.
Now, how can we solve this ?

[david garyga]

Alright.

Problem with 'm_stop = false' in start() happens when doing a quick stop(),start().
This happens at the end of a step in a sequence.

Problem with 'm_stop = false' in preRun() happens when doing a quick start(),stop().
This happens when a step in a chaser is really quick.


I'm trying to find a solution so both cases are OK...

[david garyga]

https://github.com/plugz/qlcplus/commit ... 5731e52a75

Still does'nt work. Damn.

I'm writing a big ugly array with all the cases, will post soon.

[david garyga]

https://github.com/plugz/qlcplus/tree/f ... start-stop

Seems ok with this.
But it's ugly, I'll try to find another way.

[david garyga]

(quite big) PR : https://github.com/mcallegari/qlcplus/pull/415

And a test workspace attached here, with 3 cases that could cause issues:
- a fast running chaser
- sequences
- a fast running audiotrigger (with inversed thresholds)